Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix silence trimming for flac files #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lc-guy
Copy link

@lc-guy lc-guy commented Oct 8, 2023

The FLAC plugin doesn't process the last frames while using the trim silence option, which means it only ever detects one splitpoint (and thus fails to write anything). I copied this code snippet over from the mp3 plugin to fix this. No idea if this breaks anything else, but in the specific case of trimming silence from FLAC files, it seems to work.

Headers for the file are probably gonna be messed up, though -- I'd recommend a round of ffmpeg -i <filename>.flac -c:a flac <filename>_reencode.flac afterwards. But the audio data seems intact!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant