rely on PYTHON set in Makefile/environment instead of hardcoded call to python3 in extract_assets.py #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatever pythons you have installed to use. extract_assets.py hardcodes python for subsequent scripts based on linux convention, this change pulls from environment setting of PYTHON to use that instead to allow setting in main Makefile or environment variable for cleaner portability
mountainflaw
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux convention is that a single python exists as python3, but FreeBSD, likely the others allow multiple installs and explicitly call the minor so python3.9 or python3.10 or whatever pythons you have installed on your system to use. extract_assets.py hardcodes python as python3 for subsequent python scripts used by the script, this change pulls from environment setting of PYTHON to use that instead to allow setting in main Makefile or environment variable for cleaner portability