Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Server Ciphersuite Order Preference Detection #338

Open
faldridge opened this issue Sep 25, 2018 · 5 comments
Open

Full Server Ciphersuite Order Preference Detection #338

faldridge opened this issue Sep 25, 2018 · 5 comments

Comments

@faldridge
Copy link

In order to verify certain aspects of a given server's TLS configuration, e.g., full Forward Secrecy support, sslyze should be able to detect a server's full cipher suite order preference, for those that have them.

@Jacopo
Copy link

Jacopo commented Sep 26, 2018

I have some C code that does this, would sslyze be open to integrating it?

@faldridge
Copy link
Author

I have a PR with a green build up for this, #339, but I haven't been able to get any feedback on it.

@nabla-c0d3
Copy link
Owner

Sorry, I haven't had time to look at this yet.

@nabla-c0d3
Copy link
Owner

I'm hoping to finally get to this on the next release. For now I've removed the "preferred cipher suite" functionality as it was too buggy.

When implementing cipher suite order detection, the following behavior will have to be considered: #456.

@nabla-c0d3
Copy link
Owner

I got asked about this recently, so here's an update : I've kind of given up on adding server cipher order preference, for a couple reasons:

  • AFAIK testing for it requires opening a lot of connections to the server being tested, and is a very messy process overall as it requires recursion (see "Algorithm for testing preference" in https://www.exploresecurity.com/testing-for-cipher-suite-preference/ ). SSLyze is optimised for fast, reliable, mass-scanning of servers; the "algorithm for testing preference" will be very slow (much slower than running all other plugins together), noisy, and possibly unreliable.
  • The security benefit of knowing the server's preference seems tiny to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants