Non-Regression Tests for my recent layout changes #1781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added tests to the non-regression test directory for changes I made in pull requests #1773, #1774, #1777 and #1780.
These were for issues #1680, #1679, #839 and Forum posted issues 18832 and 18816.
I also included the example you provided in #1777, which is in the test SequenceLayout_0006_Test. That one, plus a few other right side note test I now have, would have alerted me to problems with changing ArrowAndNoteBox. Enough of these tests will be very helpful.
A few of them do not fail when I roll back my code changes for testing. These seem, therefore, to have been bugs primarily in the drawing logic rather than the layout positioning that was generated in the test results. These were my tests:
Still, I decided to keep those two, just in case other changes are caught by these tests. I suspect with some future layout fixes some of these tests will fail due to the improvement rather than a regression, but at least we'll have the opportunity to examine the change in any failed test conditions to make sure they were intended.
Regards.