Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Regression Tests for my recent layout changes #1781

Merged
merged 2 commits into from
May 15, 2024

Conversation

jimnelson372
Copy link
Contributor

I added tests to the non-regression test directory for changes I made in pull requests #1773, #1774, #1777 and #1780.

These were for issues #1680, #1679, #839 and Forum posted issues 18832 and 18816.

I also included the example you provided in #1777, which is in the test SequenceLayout_0006_Test. That one, plus a few other right side note test I now have, would have alerted me to problems with changing ArrowAndNoteBox. Enough of these tests will be very helpful.

A few of them do not fail when I roll back my code changes for testing. These seem, therefore, to have been bugs primarily in the drawing logic rather than the layout positioning that was generated in the test results. These were my tests:

Still, I decided to keep those two, just in case other changes are caught by these tests. I suspect with some future layout fixes some of these tests will fail due to the improvement rather than a regression, but at least we'll have the opportunity to examine the change in any failed test conditions to make sure they were intended.

Regards.

@arnaudroques arnaudroques merged commit 2418b65 into plantuml:master May 15, 2024
9 checks passed
@jimnelson372 jimnelson372 deleted the newnonregtests branch May 15, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants