Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now works with dash! #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

KonaArctic
Copy link

Deleted bashism so it now works with dash.

I use Debian too so this fixes issue 7.

Tested to work with various combinations of bash, dash, wget, and curl.

-	Fixes issue 7
@diniciacci
Copy link

There is another line that you might want to change IMHO:

/bin/sh ./fetch-latest-widevine.sh -o ./widevine.zip

should not enforce /bin/sh, else I fear the shebang in the file executed is ignored, and the shebang selected shell is ignore (choosing another shell is a legit thing to do even if you fixed the script to a particular shell). This was what was happening locally, but I'm not an script expert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants