-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: fix toolstate publishing #125145
CI: fix toolstate publishing #125145
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
It's pretty impressive that toolstate has presumably been passing for years without a single failure |
This was broken by my large CI restructuring that was finished ~2 weeks ago. |
Ah! That makes more sense. |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (84b9b6d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary -0.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 668.459s -> 669.294s (0.12%) |
Toolstate publishing after something broke was not working (discovered here). The toolstate env. vars should only be needed for the publishing step, so I moved them there.
The toolstate script is also being checked in
mingw-check
on PR and auto CI, but it doesn't really seem to do anything, and it shouldn't require the token.