Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix toolstate publishing #125145

Merged
merged 1 commit into from
May 19, 2024
Merged

CI: fix toolstate publishing #125145

merged 1 commit into from
May 19, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 15, 2024

Toolstate publishing after something broke was not working (discovered here). The toolstate env. vars should only be needed for the publishing step, so I moved them there.

The toolstate script is also being checked in mingw-check on PR and auto CI, but it doesn't really seem to do anything, and it shouldn't require the token.

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 15, 2024
@ChrisDenton
Copy link
Contributor

It's pretty impressive that toolstate has presumably been passing for years without a single failure

@Kobzol
Copy link
Contributor Author

Kobzol commented May 15, 2024

This was broken by my large CI restructuring that was finished ~2 weeks ago.

@ChrisDenton
Copy link
Contributor

Ah! That makes more sense.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 19, 2024

📌 Commit 7b6a3d0 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2024
@bors
Copy link
Contributor

bors commented May 19, 2024

⌛ Testing commit 7b6a3d0 with merge 84b9b6d...

@bors
Copy link
Contributor

bors commented May 19, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 84b9b6d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 19, 2024
@bors bors merged commit 84b9b6d into rust-lang:master May 19, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 19, 2024
@Kobzol Kobzol deleted the ci-toolstate branch May 19, 2024 12:56
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (84b9b6d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.9% [-0.9%, -0.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.9% [-0.9%, -0.9%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.459s -> 669.294s (0.12%)
Artifact size: 316.25 MiB -> 316.25 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants