Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift FnSig to rustc_type_ir #125157

Closed
wants to merge 1 commit into from
Closed

Uplift FnSig to rustc_type_ir #125157

wants to merge 1 commit into from

Conversation

compiler-errors
Copy link
Member

:3

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 15, 2024
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

Removed some &self in favor of self so let's perf this too

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2024
@bors
Auto merge of rust-lang#125157 - compiler-errors:uplift-fn-sig, r=
940af38 
Uplift `FnSig` to `rustc_type_ir`

:3

r? lcnr
@bors
Copy link
Contributor

bors commented May 15, 2024

⌛ Testing commit f6bfc1e with merge 940af38...

@compiler-errors
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2024
lcnr
lcnr reviewed May 15, 2024
View reviewed changes
compiler/rustc_type_ir/src/inherent.rs
}

pub trait Abi<I: Interner<Abi = Self>>: Copy + Debug + Hash + Eq {
// is `extern "Rust"`?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// is `extern "Rust"`?
/// Whether this ABI is `extern "Rust"`.

@lcnr
Copy link
Contributor

lcnr commented May 15, 2024

r=me after nit + CI

@compiler-errors
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 15, 2024
@jieyouxu
Copy link
Contributor

@bors r- retry (bors seems to think this PR is approved and is not running a try-only build?)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 15, 2024
@compiler-errors
Copy link
Member Author

I feel like this branch is beyond repair

@compiler-errors compiler-errors deleted the uplift-fn-sig branch May 16, 2024 01:59
@compiler-errors compiler-errors mentioned this pull request May 16, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 16, 2024
@matthiaskrgr
Rollup merge of rust-lang#125170 - compiler-errors:uplift-fn-sig-2, r…
a8a3117 
…=lcnr

Uplift `FnSig` into `rustc_type_ir` (redux)

Since the last one got so messed up with `try` build.

rust-lang#125157 (comment)

r? lcnr
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2024
@rust-timer
Unrolled build for rust-lang#125170
4308224 
Rollup merge of rust-lang#125170 - compiler-errors:uplift-fn-sig-2, r=lcnr

Uplift `FnSig` into `rustc_type_ir` (redux)

Since the last one got so messed up with `try` build.

rust-lang#125157 (comment)

r? lcnr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@compiler-errors @rust-timer @bors @lcnr @jieyouxu @rustbot