-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uplift FnSig
into rustc_type_ir
(redux)
#125170
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…try> Uplift `FnSig` into `rustc_type_ir` (redux) Since the last one got so messed up with `try` build. r? lcnr
} | ||
|
||
pub trait Abi<I: Interner<Abi = Self>>: Copy + Debug + Hash + Eq { | ||
// is `extern "Rust"`? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update this still
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (9156367): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 678.078s -> 679.272s (0.18%) |
9d0b5be
to
312ba4d
Compare
@bors r=lcnr rollup |
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124871 (Don't ICE because recomputing overflow goals during find_best_leaf_obligation causes inference side-effects) - rust-lang#125018 (Update linker-plugin-lto.md to include LLVM 18) - rust-lang#125130 (rustdoc-json-types: Document `Id`) - rust-lang#125170 (Uplift `FnSig` into `rustc_type_ir` (redux)) - rust-lang#125172 (Fix assertion when attempting to convert `f16` and `f128` with `as`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#125170 - compiler-errors:uplift-fn-sig-2, r=lcnr Uplift `FnSig` into `rustc_type_ir` (redux) Since the last one got so messed up with `try` build. rust-lang#125157 (comment) r? lcnr
Since the last one got so messed up with
try
build.#125157 (comment)
r? lcnr