Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename inner selector in seletor to subselector #147

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

toge
Copy link
Contributor

@toge toge commented Dec 24, 2023

Thank you for relaxing compiler requirements on lunasvg/2.3.9.

I met compilation error on gcc 5.4.0.

source/parser.cpp: In static member function ‘static bool lunasvg::RuleData::matchPseudoClassSelector(const lunasvg::PseudoClassSelector&, const lunasvg::Element*)’:
source/parser.cpp:1229:30: error: use of ‘selector’ before deduction of ‘auto’
         for(auto& selector : selector.subSelectors) {
                              ^
source/parser.cpp:1230:29: error: unable to deduce ‘auto&&’ from ‘selector’
             for(auto& sel : selector) {
                             ^
source/parser.cpp:1241:30: error: use of ‘selector’ before deduction of ‘auto’
         for(auto& selector : selector.subSelectors) {
                              ^
source/parser.cpp:1242:29: error: unable to deduce ‘auto&&’ from ‘selector’
             for(auto& sel : selector) {
                             ^

Those errors are caused by same symbol name in for loops.
If possible, woudl you merge this PR to work well on old gcc compilers.

@sammycage sammycage merged commit ef62fac into sammycage:master Dec 24, 2023
3 checks passed
@sammycage
Copy link
Owner

Thank you 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants