Make sync and async generators restore the initialization context #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Aug 1, 2023
littledan
reviewed
Aug 2, 2023
| 1. Push _genContext_ onto the execution context stack; _genContext_ is now the running execution context. | ||
| 1. <emu-meta effects="user-code">Resume the suspended evaluation of _genContext_</emu-meta> using NormalCompletion(_value_) as the result of the operation that suspended it. Let _result_ be the value returned by the resumed computation. | ||
| 1. Assert: When we return here, _genContext_ has already been removed from the execution context stack and _methodContext_ is the currently running execution context. | ||
| 1. <ins>AsyncContextSwap(_asyncContextMapping_).</ins> |
There was a problem hiding this comment.
Nit: Write this as "Perform AsyncContextSwap(asyncContextMapping)."
There was a problem hiding this comment.
Actually we should probably follow this with an assert that it doesn't matter whether we are discarding or saving/restoring.
There was a problem hiding this comment.
There are steps that just do "AsyncContextSwap(previousMapping)" in the existing spec text.
I will add that assertion though.
legendecas
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18.