Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Effect" is undefined in Computed.get #202

Open
prophile opened this issue Apr 29, 2024 · 2 comments · May be fixed by #221
Open

"Effect" is undefined in Computed.get #202

prophile opened this issue Apr 29, 2024 · 2 comments · May be fixed by #221

Comments

@prophile
Copy link
Contributor

The algorithm specification for "Method: Signal.Computed.prototype.get" says this in phase 1:

If the current execution context is notifying or if this Signal has the state ~computing~, or if this signal is an Effect and computing a computed Signal, throw an exception.

There's no other reference to an "Effect" so it's not clear what this means. There are some references to "effect Signal" elsewhere but this is also not defined anywhere.

@EisenbergEffect
Copy link
Collaborator

Good catch @prophile! I think this is some language left over from an earlier draft of the proposal. @littledan Should this just be updated to say Watcher or is there a more involved change here?

@littledan
Copy link
Member

Yes, we should just be referring to Watcher here.

littledan added a commit that referenced this issue May 13, 2024
@littledan littledan linked a pull request May 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants