Normative: Fix bug with PlainDateTime since/until near month boundaries #2838
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arshaw
changed the title
|
CC @ptomato, @justingrant and team |
ptomato
approved these changes
May 14, 2024
|
@ptomato, I'd be really appreciative of some help with the spec text |
ljharb
reviewed
May 14, 2024
… sign compatibility by backing-off from wrong end and erroneously falling across month boundaries
ptomato
force-pushed
the
2820-pdt-diff-month-boundary
branch
from
1e36143
to
25d5e3e
Compare
Spec text changes corresponding to previous commit, fixing bug where PlainDateTime since/until would maintain date/time-diff sign compatibility by backing-off from wrong end and erroneously falling across month boundaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2820
Fix bug where PlainDateTime since/until would maintain date/time-diff sign compatibility by backing-off from wrong end and erroneously falling across month boundaries
Tests: https://github.com/tc39/test262/pull/4078/files