-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAB: Integrate staging tests for .fill method #4075
base: main
Are you sure you want to change the base?
Conversation
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments about the description.
/*--- | ||
esid: sec-%typedarray%.prototype.fill | ||
description: > | ||
Array.p.fill behaves correctly when the receiver is backed by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array.p.fill behaves correctly when the receiver is backed by | |
TypedArray.p.fill behaves correctly when the receiver is backed by |
/*--- | ||
esid: sec-array.prototype.fill | ||
description: > | ||
Array.p.fill called on a TypedArray backed by a resizable buffer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array.p.fill called on a TypedArray backed by a resizable buffer | |
Array.p.fill called on a TypedArray backed by a resizable buffer | |
that goes out of bounds during evaluation of the arguments |
of Array.prototype and TypedArray.prototype
This is part of PR #3888 to make reviewing easier.
Includes changes to use the helper ./harness/resizableArrayBufferUtils.js