Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matching/spatial.go: dvorak same as QWERTY #8

Open
kardianos opened this issue May 16, 2019 · 1 comment
Open

matching/spatial.go: dvorak same as QWERTY #8

kardianos opened this issue May 16, 2019 · 1 comment

Comments

@kardianos
Copy link

It looks like there is a copy/paste error where devorak has the same shiftedChars as QWERTY.

@vanackere
Copy link
Contributor

You're right... but this is not really a copy-paste error: the reference dropbox/zxcvbn coffeescript code uses the same array for both layout. I also noticed this during development of this library - therefore the two separate - but identical - entries, but we want to keep the exact same scoring as upstream, including potential bugs like this unfortunately...

https://github.com/dropbox/zxcvbn/blob/master/src/matching.coffee#L239

You might want to open a bug against the dropbox project, once fixed there I will gladly update the shiftedChars with the proper value.

Also the library currently misses proper AZERTY support (like upstream) and this should ideally be fixed in the dropbox project first.
We might consider implementing changes not compatible with upstream, protected by a global option in the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants