-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open.spotify.com: ads / breakages #22198
Comments
same |
It seems to works for me. ||creativeservice-production.scdn.co/mp3-ad/$media,redirect=noop-1s.mp4:10,from=open.spotify.com uBlock Origin: 1.55.0
Chromium: 121
filterset (summary):
network: 130377
cosmetic: 116430
scriptlet: 27288
html: 0
listset (total-discarded, last-updated):
removed:
urlhaus-1: null
plowe-0: null
added:
https://easylist-downloads.adblockplus.org/bitblock.txt: 26081-19, 22h.22m
https://easylist-downloads.adblockplus.org/cntblock.txt: 1698-26, 9h.24m
https://www.awwwwesome.org/url-blocklist/url-blocklist.txt: 1656-0, 9h.24m
adguard-cookies: 28457-246, 23m
ublock-annoyances: 6585-44, 4h.3m Δ
default:
user-filters: 4-0, never
ublock-filters: 36678-107, 4h.3m Δ
ublock-badware: 7791-10, 4h.3m Δ
ublock-privacy: 992-9, 4h.3m Δ
ublock-unbreak: 2192-6, 4h.3m Δ
ublock-quick-fixes: 128-6, 4h.3m Δ
easylist: 79607-251, 4h.3m Δ
easyprivacy: 43562-403, 4h.3m Δ
RUS-0: 40155-277, 4h.23m Δ
filterset (user): [array of 4 redacted]
userSettings:
advancedUserEnabled: true
contextMenuEnabled: false
showIconBadge: false
hiddenSettings:
cacheStorageAPI: indexedDB
filterAuthorMode: true
popupPanelHeightMode: 1
trustedListPrefixes: ublock- user-
supportStats:
allReadyAfter: 942 ms (selfie)
maxAssetCacheWait: 568 ms
cacheBackend: indexedDB
popupPanel:
blocked: 10
network:
cookielaw.org: 1
doubleclick.net: 4
googleoptimize.com: 1
sentry.io: 4
extended:
##+js(remove-node-text, script, cookieUpdateConsentUrl)
##+js(remove-attr, jsaction, #islsp c-wiz a[href^="http"][data-v…
##+js(set-constant, rwt, noopFunc)
##+js(trusted-set-cookie, SOCS, CAESHAgBEhJnd3NfMjAyMzA2MTItMF9S… |
We had many issues opened for spotify: https://github.com/uBlockOrigin/uAssets/issues?q=is%3Aissue+open.spotify.com Maybe we should put a megathread for this site? |
Also I see a lot of comments on reddit.com, so let's create one megathread. |
I suggested a different approach to the Spotify Web Client ads taken from the desktop adblock "BlockTheSpot" linked here: Essentially the desktop client is is a browser engine that downloads, executes and renders the same files from the same web-server as the web client runs on. So, using their method, you can not only disable ad distribution completely, but also enable other features that usually only premium members get access to. Unfortunately I was not aware of this issues existence. |
uBO blocking works by filters. Specific solutions for specific sites that need deeper modifications to the scripts require dedicated scripts for it, which can only be updated when the whole extension updates. It's better to leave those solutions to dedicated extensions. |
FYI: That's out of scope, we don't fix paywalls to features. Only the ads will be blocked. |
@ItsProfessional That's fine. @stephenhawk8054 Yeah, but does uBO not have the ability to inject scripts? If so, could you inject something that changes the default state of a JS boolean or change some site specific code? Take a look at the issue I posted to see what I mean, they essentially just wait for the browser engine to read a certain file and then patch it up. |
@gettysburg Scripts injection works by using a set of pre-defined scriptlets: https://github.com/gorhill/uBlock/wiki/Resources-Library We don't write arbitrary long scripts for specific sites. As I said, that can only be maintained and updated when the whole extension updates. It cannot be updated frequently like filters whenever the site changes something. |
We want to avoid code manipulation (i.e. patches) to the site's scripts whenever possible, as this is basically RCE. |
Anyone knows if using |
Yeah, the ads connections look quite random. Sometimes I got |
Can anyone test if this filter can stop any open.spotify.com##+js(trusted-replace-fetch-response, /\,\{"metadata":\{"uri":"spotify:ad:.+?:"AD"\}/, , track-playback) |
As i mentioned in #22258, i didn't have any issues with visual adds showing up but the songs would start skipping, and whats really irritating is that it doesn't happen every time |
@Luminous-Journey Can you do these steps (follow strictly the step order, don't mix the steps orders, or skip any steps):
|
Unfortunately, while i was attempting to troubleshoot, the bug fixed itself and now i cant record it until it happens again, and who knows when that will be, but when it does i will do as recommended and when i say fixed itself, i mean it stopped happening in that instance and this has been a recurring issue |
Also @stephenhawk8054 do you want the markdown or plaintext version? |
@Luminous-Journey Any is fine. |
Another bug that i ran into with the same config is when a song is playing like an ad where you cant skip forward and it says advertisment in the bottom right, managed to record this one log: https://www.logpasta.com/paste/91b347d8-8925-4e30-9fc8-eb17e5db82f5 |
So the logger only logs when its in the foreground of the page attempting to be logged? |
The logger needs to be opened first to start capturing information. Then depending on which tab you are opening, it will show the information from that tab. You can switch the tab in the logger's drop down. @Luminous-Journey But anyways, can you do these steps:
Then can you test these filters? open.spotify.com##+js(trusted-replace-fetch-response, /\,\{"metadata":\{"uri":"spotify:ad:.+?:"AD"\}/, , track-playback) Click on uBO icon > ⚙ Dashboard button > Add the filter(s) in "My filters" pane > ✓ Apply changes > Open new tab and test again. Please also double-check again to see if the filters are marked as valid or invalid (it will show red line if invalid, otherwise it's good). |
The filter seems to be valid, I will post back here if something happens again. Tysm |
Thats good, I had the dropdown set to the spotify tab, and had opened the logger before reloading that page |
@dportvine Keep the above filter, can you continue adding this? open.spotify.com##+js(trusted-replace-fetch-response, "disallow_seeking":true, "disallow_seeking":false, track-playback) |
Didn't help. |
Hmm... I don't know how to resolve more. I can reproduce the issue, but cannot any more after adding that filter |
Nothing has changed for me. VideoVideo_2024-01-29_104327.mp4 |
RCE, aka remote code execution, is not the correct term here. The dynamic library from "BlockTheSpot" is patching This does not qualify as RCE whatsoever, as all changes are done locally and in the users favor, there is no harm, and no code execution that wouldn't occur otherwise. Regardless, this was just a suggestion, if this is currently not possible as explained by @stephenhawk8054, then it's okay and the current approach of just playing 1 second noop files is good enough I guess, I managed to find an installer with which BlockTheSpot works, so I don't have to use the web player anymore: Thank you regardless @ItsProfessional and @stephenhawk8054 for your hard work, and for your replies :-) |
@gettysburg RCE will be determined by the extension store reviewers. You can argue whatever you want, but the final decision is by them. Any potential argument would be a potential issue of wasting time for back-and-forth questions/explanations and potential for delay/deny of future versions' publishing. |
@stephenhawk8054 I have to admit that I did not take Mozilla's review team into consideration, and the way that these new filters allowing for file modification could be abused by (third party) filter-list maintainers. Thank you for bringing that up, I totally have not thought of that. |
@dportvine This is a POC test, can you test if this skips the ads faster? open.spotify.com##+js(trusted-replace-fetch-response, '/(\{"uri":"spotify:ad:.+?,"manifest"):.+?,"audio_id":/', '$1:{"file_urls_mp3":[{"bitrate":160000,"file_id":null,"file_url":"https://cdn.jsdelivr.net/gh/stephenhawk8054/external_resources@master/noop-0.1s.mp3","impression_urls":[""],"track_type":"AUDIO","format":null,"audio_quality":null,"hifi_status":null,"gain_db":null,"expires_at":null}]},"audio_id":', track-playback) The idea is replacing their mp3 ads with an external mp3 file |
@dportvine Can you check the logger to see which connections appear at that? |
I checked again. And now I don't see any problems. VideoVideo_2024-02-01_094452.mp4 |
I managed to get that one issue logged where the songs just skip instead of playing @stephenhawk8054 |
But now it's fixed itself again... |
@Luminous-Journey Remove the custom filters I told you to test and check if your original issue is still there or not. If I understand correctly, your original issue is the player was stuck and could not advance right? |
It would advance, but it would simply skip all the subsequent songs instead of playing them |
@Luminous-Journey That's strange. For now just remove the current custom filters and see if the issue is still there or not. Also check your other extensions if possible too. |
You mean this one? or the lists? |
@Luminous-Journey Yeah, the ones I told you to add in |
Prerequisites
URL address of the web page
https://open.spotify.com/
Category
ads
Description
Today, the site starting showing ads while having uBlock Origin activated.
Other extensions used
None.
Screenshot(s)
Screenshot(s)
Configuration
The text was updated successfully, but these errors were encountered: