Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubereats.com: ads #23707

Closed
10 of 11 tasks
aldobarr opened this issue May 15, 2024 · 6 comments
Closed
10 of 11 tasks

ubereats.com: ads #23707

aldobarr opened this issue May 15, 2024 · 6 comments

Comments

@aldobarr
Copy link

aldobarr commented May 15, 2024

Prerequisites

  • This is NOT a YouTube, Facebook, Twitch or a shortener/hosting site report. These sites MUST be reported by clicking their respective links.
  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Search here to find out.)
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin along with other content blockers.
  • I have verified that the web browser's built-in content blocker/tracking protection, network wide/DNS blocking, or my VPN is not causing the issue.
  • I have verified that other extensions are not causing the issue.
  • If this is about a breakage or detection, I have verified that it is caused by uBlock Origin and isn't a site issue.
  • I did not answer truthfully to ALL the above checkboxes.

URL(s) where the issue occurs.

https://www.ubereats.com/orders/{ORDER-ID}

Description

There are some new ads on the order page after an order has been placed.

Other extensions used

betterTTV
bitwarden
clickbait remover for youtube
don't fuck with paste
greasemonkey (only 1 script which only interacts on twitch.tv)
hide private mode
return youtube dislike
sponsorblock for youtube
ttv lol pro
translate web pages
youtube high definition
youtube nonstop
youtube spam remover

Screenshot(s)

Screenshot(s)

image

Configuration

uBlock Origin: 1.57.2
Firefox: 125
filterset (summary):
 network: 187584
 cosmetic: 49816
 scriptlet: 24739
 html: 2061
listset (total-discarded, last-updated):
 added:
  https://gitlab.com/magnolia1234/bypass-paywalls-clean-filters/-/raw/main/bpc-paywall-filter.txt: 0-0, never
  https://raw.githubusercontent.com/liamengland1/miscfilters/master/antipaywall.txt: 2098-0, 5m
  adguard-spyware-url: 1512-120, 8m
  fanboy-thirdparty_social: 68-0, 8m
  ublock-annoyances: 5823-38, 8m
  adguard-spyware: 83498-31917, 8m
 default:
  user-filters: 5-0, never
  ublock-filters: 38196-118, 9m
  ublock-badware: 8548-0, 9m
  ublock-privacy: 907-3, 9m
  ublock-unbreak: 2332-2, 8m Δ
  ublock-quick-fixes: 193-5, 8m Δ
  easylist: 87514-169, 8m
  easyprivacy: 50907-75, 8m
  urlhaus-1: 12635-3, 8m
  plowe-0: 3729-1160, 8m
filterset (user): [array of 5 redacted]
trustedset:
 added: [array of 7 redacted]
hostRuleset:
 added: [array of 8 redacted]
urlRuleset:
 added: [array of 442 redacted]
userSettings:
 advancedUserEnabled: true
hiddenSettings: [none]
supportStats:
 allReadyAfter: 154 ms (selfie)
 maxAssetCacheWait: 43 ms
 cacheBackend: indexedDB
popupPanel:
 blocked: 74
 network:
  ubereats.com: 74
 extended:
  ##.dw.ec
  ##+js(set-constant, Navigator.prototype.globalPrivacyControl, fa…
  ##+js(set-constant, navigator.globalPrivacyControl, false)
@stephenhawk8054 stephenhawk8054 changed the title Ubereats New Ads ubereats.com: ads May 15, 2024
@aldobarr
Copy link
Author

@stephenhawk8054 I order quite often. Happy to help with my account if needed.

@stephenhawk8054
Copy link
Member

@aldobarr The label is just to inform any others who want to look at the case that the issue needs an account to reproduce.

Can you right click on the ads -> Click on Inspect -> It will open Firefox devtools -> Screenshot it here? (It would be better if you can drag the devtools to be bigger before screenshot)

@aldobarr
Copy link
Author

@aldobarr The label is just to inform any others who want to look at the case that the issue needs an account to reproduce.

Can you right click on the ads -> Click on Inspect -> It will open Firefox devtools -> Screenshot it here? (It would be better if you can drag the devtools to be bigger before screenshot)

@stephenhawk8054 The last time I ordered I didn't get an ad. Just a self promo to upgrade ubear eats pro. Example:

no_ad
no_ad.txt

Thought you might want to see that too. I got the ads back this morning:
yes_ad
yes_ad.txt

Included the actual dom contents as a text file as well in both cases.

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented May 22, 2024

Yeah, this is difficult to make if just based on the DOM. You can try this as a custom filter

ubereats.com##:matches-path(/orders) main#main-content ol[style^="transform"]:has(> li > a[href]):has-text(Ad)

but I'm not sure if it would cause breakages somewhere else or not.

@aldobarr
Copy link
Author

Order just got delivered so I'll try it out next time. Also realistically the only thing that matters on the order page is the delivery estimate and the map. The rest is just fluff imo.

@stephenhawk8054
Copy link
Member

I'll convert this to a discussion. It's still a risky filter so anyone can test themselves as a custom filter

@uBlockOrigin uBlockOrigin locked and limited conversation to collaborators May 22, 2024
@stephenhawk8054 stephenhawk8054 converted this issue into discussion #23798 May 22, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

2 participants