Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shorter aliases for C++ sim #492

Closed
wants to merge 3 commits into from

Conversation

Starlight220
Copy link
Member

Fixes #480

@Starlight220
Copy link
Member Author

What's up with the CI? I haven't been able to understand why it failed (and whether it's my fault).

@ThadHouse
Copy link
Member

CI is just an infrastructure error. The issue I have with this is its going to completely break if a user had 2 native executables in the same project. Its rare, but we can't just have the build fail when that occurs. The way I envision doing this is creating a custom task for simulateCpp, that contains a list of components it can run. If just 1 is found, it works fine, if multiple are found, it doesn't run anything, and instead prints a message saying the user needs to set a variable for which executable they want ran with simulateCpp.

That might end up being easier in 2022, as I plan on making some changes to extend on top of the native executable model to make things like this easier.

Base automatically changed from master to main January 30, 2021 19:30
@Starlight220
Copy link
Member Author

TODO: Add a C++ test task

@ThadHouse
Copy link
Member

This is OBE and fixed for 2022. The users have to explicitly mark which component gets the simulate task, so the issue with the duplicate build failing is gone as well.

@ThadHouse ThadHouse closed this Oct 6, 2021
@Starlight220 Starlight220 deleted the simulateCpp branch October 7, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shorter task alias for C++ test execution
2 participants