Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss is we should run tests on deploy by default #497

Open
ThadHouse opened this issue Feb 19, 2021 · 3 comments
Open

Discuss is we should run tests on deploy by default #497

ThadHouse opened this issue Feb 19, 2021 · 3 comments

Comments

@ThadHouse
Copy link
Member

At least at some point, running a deploy would also run tests. We have a flag in vscode to skip this behavior, and it's documented. I'm not actually sure that's the case anymore. We should discuss what behavior we want for this so we can make it right in 2022

@Starlight220
Copy link
Member

tests would run on deploy if deploy depended on build. Since it doesn't, then tests would never run on deploy.

@ThadHouse
Copy link
Member Author

Is that the behavior we want? That's what this issue if for, so we can get the behavior we want.

@Starlight220
Copy link
Member

Since many teams rarely simply build but usually only deploy, the tests will almost never be run if they don't run on deploy. On the other hand, running tests could fail/delay a critical deploy at an event or something.
Either way, the configure option in VS Code should work as well as a way to set without vscode (ie a gradle property or whatever). The point of discussion is what the default should be IMO.

I suggest opening this up for community discussion, perhaps on CD or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants