Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if WPILib JDK isn't found #627

Open
Starlight220 opened this issue Nov 24, 2022 · 2 comments
Open

Warn if WPILib JDK isn't found #627

Starlight220 opened this issue Nov 24, 2022 · 2 comments

Comments

@Starlight220
Copy link
Member

(Not sure if this issue should be here or in the installer repo, or both. Transfer if needed)

Using a different JDK can cause all kinds of issues, such as character encoding problems in the Java-based tools. We should warn if the WPILib-installed JDK isn't found, with a link to the installer etc.

@rzblue
Copy link
Member

rzblue commented Nov 24, 2022

I don't know if I'd want to warn with GradleRIO, to be honest. I understand the need for it - I just don't think "forcing" it into GradleRIO is the right move.

@ThadHouse
Copy link
Member

Well it would just be a warning. However, GradleRIO isn't a great place for it, as the logic gradlerio uses is different then the logic the tools use. The only way to do this right would be to have the tool scripts check, but thats invasive too. I'm not really sure how to do this best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants