Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect romi project during project import #528

Open
jpokornyiii opened this issue Mar 31, 2022 · 4 comments
Open

Detect romi project during project import #528

jpokornyiii opened this issue Mar 31, 2022 · 4 comments

Comments

@jpokornyiii
Copy link

When I tried importing some older romi projects, it wiped out my environment variable and simulation extension. I needed to add them back manually. Can these lines be added to the build.gradle file for romi projects? Basically, this:

dependencies {
...
simulation wpi.deps.sim.ws_client(wpi.platforms.desktop, false)
}

sim {
envVar "HALSIMWS_HOST", "10.0.0.2"
}

Needs to translate to this:

wpi.sim.addWebsocketsClient().defaultEnabled = true
wpi.sim.envVar("HALSIMWS_HOST", "10.0.0.2")

@jpokornyiii
Copy link
Author

I believe this is what led to the confusion in wpilibsuite/WPILibPi#222

@ThadHouse
Copy link
Member

This is actually caused by the project importer not knowing about romi projects, and just assuming its a normal robot project. For 2023 I can investigate making the importer detect romi projects, and use the romi templates instead of the normal templates.

@ThadHouse ThadHouse changed the title Need to update romi build.gradle on imports Detect romi project during project import Mar 31, 2022
@jpokornyiii
Copy link
Author

Gotcha. Yeah, can we add this to the backlog of 2023 work? Let me know if you need help.

@sciencewhiz
Copy link
Contributor

#544 does the manually, but not automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants