Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove required vendordep.json properties which aren't used and aren't required #210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ggoebel
Copy link

@ggoebel ggoebel commented Feb 5, 2019

vendordeps phoenix.json and navx_frc.json aren't using:

  • isHeaderOnly
  • hasSources
  • skipOnUnknownClassifier
  • validClassifiers
  • sourcesClassifier

The following patch will prevent the wpilib-vscode extension from identifying these absences as problems. I.e. we can't control 3rd party vendor errors. So please stop polluting our ide with errors which we can't control and have to ignore.

@ThadHouse
Copy link
Member

Instead of just removing, the validation should be updated to the new specification. What GradleRio expects can be found here

https://github.com/wpilibsuite/GradleRIO/blob/master/src/main/groovy/edu/wpi/first/gradlerio/wpi/dependencies/WPIVendorDepsExtension.groovy#L185

Base automatically changed from master to main January 30, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants