Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block special character for project name #283

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

WuYuanhun
Copy link
Contributor

add special character validation for project name
(issue #273 & #63)

@WuYuanhun WuYuanhun closed this Oct 15, 2019
@WuYuanhun WuYuanhun reopened this Oct 15, 2019
@sciencewhiz
Copy link
Contributor

Does this only block it on the project name or also in the project path? There's also been instances of the later.

I think it's too restrictive. For example underscore and hyphens are blocked. It might be better to block known bad characters then whitelist a limited subset.

@WuYuanhun
Copy link
Contributor Author

Does this only block it on the project name or also in the project path? There's also been instances of the later.

I think it's too restrictive. For example underscore and hyphens are blocked. It might be better to block known bad characters then whitelist a limited subset.

Then We need to set up a blacklist.

The project name block strategies will be

  • string started with or ended with symbols are not allowed
  • string started with or ended with space are not allowed
  • string with blacklist character

The path block strategies will be

  • path with blacklist character
  • path with whitespace

@ThadHouse
Copy link
Member

ThadHouse commented Oct 16, 2019

We can't block paths with white space too many users have a space in their username. The project name is the only one we need to block white space from

@WuYuanhun
Copy link
Contributor Author

WuYuanhun commented Oct 16, 2019

We can't block paths with white space too many users have a space in their username

I see.

update project name and path valiadtion

project name block strategies
- string started with or ended with  symbols are not allowed
- string started with or ended with space are not allowed
- string with blacklist character

path block strategy:
- path with blacklist character
update validators: space are not allowed in project name
Base automatically changed from master to main January 30, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants