Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doodstream] add so domain and manage all links #3119

Closed
wants to merge 6 commits into from
Closed

[doodstream] add so domain and manage all links #3119

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 19, 2022

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

doodstream has a new domain .so, now it's supported

@Ashish0804
Copy link
Contributor

Add a test for it

@ghost
Copy link
Author

ghost commented Mar 19, 2022

Add a test for it

ok done, but free videos on doodstream after 60 days are deleted, all other videos are unavailable

@ghost
Copy link
Author

ghost commented Mar 19, 2022

I pushed also a fix for #3120

@ghost ghost changed the title [doodstream] add also so domain [doodstream] add so domain and manage all links Mar 19, 2022
yt_dlp/extractor/doodstream.py Outdated Show resolved Hide resolved
yt_dlp/extractor/doodstream.py Outdated Show resolved Hide resolved
yt_dlp/extractor/doodstream.py Outdated Show resolved Hide resolved
@pukkandan pukkandan added site-enhancement Feature request for some website site-bug Issue with a specific website pending-fixes PR has had changes requested labels Mar 19, 2022
@pukkandan pukkandan linked an issue Mar 19, 2022 that may be closed by this pull request
7 tasks
@ghost
Copy link
Author

ghost commented Mar 20, 2022

thank you @pukkandan for all suggestions

@ghost ghost requested a review from pukkandan March 20, 2022 05:08
@pukkandan pukkandan removed the pending-fixes PR has had changes requested label Mar 20, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doodstream] support for all links
2 participants