-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed tubitv extractor #9975
Fixed tubitv extractor #9975
Conversation
Signed-off-by: Ben Galliart <bgallia@gmail.com>
Signed-off-by: Ben Galliart <bgallia@gmail.com>
Fixes #9937 |
who is? |
This is a patch to existing yt-dlp code. The majority of the file I don't own. Of the approx. 20 lines I add, most are largely based lines already there. I didn't consider anything in the pull request to be deserving of being a new "copyrighted" work that I would own. The patch is derivative and not deserving of being considered transformative. I think all the credit still belongs with the author that came before me. If you need me to claim the code is "my own" then I will. The only source of inspiration was the code already available to me from the project. I am fine with releasing all claim that I might have to the code to be consistent with the yt-dlp license. |
You are vouching for authorship of the patch, not the code you didn't add/change/remove. The pre-existing code is already licensed under Unlicense and is not the issue. |
I authored the derivations of the code to produce the patch. No one else has a valid calm to authorship of this patch. |
Great, please fill out the PR template accordingly -- this is necessary for licensing reasons |
PR template is now updated. Sorry about my confusion regarding my understanding of "original author." |
Authored by: bashonly
Authored by: bashonly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jules-A would you mind testing this?
Has major issues: Only finds 20 entries, only got 404s when it tried to download.
The switch away from using the API seems like a weird thing to do, the webpage only loads 20 entries at once. Idk if it's helpful but this is the userscript I made a while ago to list all the episodes for extraction since there's no TubiTV playlist extractor: https://pastebin.com/raw/qVKtcYNT (very messy since I was too lazy) . Still seems to extract the ids just fine for all seasons from browser. |
The series/show extractor was not touched by this PR. It has always extracted from the webpages. I was asking if you could test the video extractor |
It removes /oz/ ? Which is the API. |
The video extractor removed the API and migrated to web. But the ShowIE has always used the webpage. Look at the code for the series extractor; it is unchanged |
The ShowIE is not the subject of this PR and thus will not be fixed in this PR. But I will push something so it at least doesn't give 404s |
Oh whoops, right, my bad. Yeah the playlist extractor never worked anyway and extracting a single show seems to be working fine in some quick tests. Sorry I'm very tired right now. |
@Jules-A all good, thank you for testing |
Authored by: bashonly
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Fixes the tubitv extractor. Previously the metadata was provided directly as json at it's own url. The website has since been revised such that this json data is embedded in the webpage itself.
Fixes #9937
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?