Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENet Timeouts Linear Change Depricated Settings #50

Open
astoll opened this issue Mar 22, 2024 · 0 comments
Open

ENet Timeouts Linear Change Depricated Settings #50

astoll opened this issue Mar 22, 2024 · 0 comments

Comments

@astoll
Copy link

astoll commented Mar 22, 2024

I was looking through the flow to try to understand the timeout values supplied to enet_peer_timeout and I'm not understanding the purpose of timeoutMinimum. I traced a change back to commit f2c0ec3 where enet timeouts were changed from exponential back-off to a more linear approach and I viewed the linked cubik.org discussion and perhaps the change is fine, but I can't see the purpose of timeoutMinimum with that change as roundTripTimeout will never be greater/equal to roundTripTimeoutLimit unless timeoutLimit is 0 or 1 which I wouldn't think would be a valid case?

Perhaps I'm misunderstanding the purpose of this change? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant