Could we have an option to highlight the line number? #764
Replies: 8 comments 6 replies
-
|
Visual Studio 2022 and VSCode both have this feature, cc @nyamatongwe |
Beta Was this translation helpful? Give feedback.
-
|
If someone wants to implement it fully, it can go in. To me it's low value bloat, just duplicating an existing feature with a slightly different appearance. |
Beta Was this translation helpful? Give feedback.
-
|
I could see many requests for this function. Pls do consider implementing this feature. Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
I just read that for margin 0 you could not specify a different color for some specific lines. But for margin 1 you could do it. That needs some more work. I wonder if someone could make some modifications to fulfill this function. |
Beta Was this translation helpful? Give feedback.
-
|
Following is the code that draws line number text, to implement this feature, I think there needs a new |
Beta Was this translation helpful? Give feedback.
-
|
Could we use it directly? I will try later. Earlier I tried to use the bookbark margin to show the caret line, as a makeshift, but failed - only line 1 is bookmarked and for other lines the bookmark won't show, and the bookmark at line 1 won't disappear when current line changes... Have to read more and understand more from the codes. |
Beta Was this translation helpful? Give feedback.
-
|
Just read the code and see it's just a quote. Someone familiar with Scintilla has to rewrite the function for implementation. Well, hopefully someone will do it soon. |
Beta Was this translation helpful? Give feedback.
-
The previous and new line numbers may also need to be invalidated for redraw. Take care as there has been work on avoiding unnecessary invalidations as they are sometimes a significant cost.
I expect |
Beta Was this translation helpful? Give feedback.
-
|
Not yet working on this. I was thought invalidation is not required as the margin is whole redrawn? P.S. Xcode, Android Studio and Sublime Text all have this feature. Sublime Text change both fore and back color for caret line. |
Beta Was this translation helpful? Give feedback.
-
See |
Beta Was this translation helpful? Give feedback.
-
|
OK. |
Beta Was this translation helpful? Give feedback.
-
|
@zufuliu How is the progress? Could it be done or not? |
Beta Was this translation helpful? Give feedback.
-
|
I'm not working on this. I thought you already have code to highlight line number like the image in your first post? |
Beta Was this translation helpful? Give feedback.
-
|
Oh, that's a pity. My post was only a demo to show the look of the result that I hoped to get. Would you go on with it?
…---Original---
From: "Zufu ***@***.***>
Date: Tue, Apr 23, 2024 18:20 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [zufuliu/notepad2] Could we have an option to highlight the linenumber? (Discussion #764)
I'm not working on this. I thought you already have code to highlight line number like the image in your first post?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
When highlighting the current line, either highlight with background color or outline frame is not pretty. The color or the frame pollutes the text. I think to highlight the line number might be a good idea. You could see clearly where the current line is, and the text is not contaminated. This should be an ideal way to highlight the current line. Please give it a try. Thanks!
Beta Was this translation helpful? Give feedback.
All reactions