Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LongPtr colouring #735

Open
meteorquake opened this issue Nov 13, 2023 · 6 comments
Open

LongPtr colouring #735

meteorquake opened this issue Nov 13, 2023 · 6 comments

Comments

@meteorquake
Copy link

meteorquake commented Nov 13, 2023

In this line in Visual Basic -
lStructSize As Long: hwndOwner As LongPtr
"LongPtr" is not coloured as "Long". Although a pseudotype, I think it should be coloured just the same :)
Cheers, David

@zufuliu zufuliu added this to the v4.23.11 milestone Nov 14, 2023
zufuliu added a commit that referenced this issue Nov 14, 2023
@zufuliu
Copy link
Owner

zufuliu commented Nov 14, 2023

Fixed by b64e2a4.

@meteorquake
Copy link
Author

meteorquake commented Nov 14, 2023

Cheers! Now just looking at that destination list there should also be coloured as CLng -
CCur CVar CVErr CLngLng CLngPtr CVDate

(Technically CVDate could be argued not to be coloured but I think it is helpful to be.)

and also coloured as String -
Currency LongLong LongPtr
In addition Variant should be coloured to match those

I'll have a look for others.

@meteorquake
Copy link
Author

Sorry that wasn't meant to close it, the drop list was ambigous!

@meteorquake meteorquake reopened this Nov 14, 2023
@zufuliu
Copy link
Owner

zufuliu commented Nov 14, 2023

Now just looking at that destination list there should also be coloured as CLng

Done in 6fcc170.

@zufuliu zufuliu closed this as completed Nov 18, 2023
@meteorquake
Copy link
Author

Cheers that looks good! I'm just going to add new entries here as I encounter them which you might want to process periodically.
New addition:
PtrSafe should be coloured same as Function

@zufuliu
Copy link
Owner

zufuliu commented Nov 21, 2023

function list will be added later (when LexVB.cxx is rewritten, keywords in stlVB.c and stlVBS.c will be changed to auto-generating from API files), I already have incomplete API files for VB and VBS, you can post document links for keyword, function and constant, etc. here. I can add them into the API file.

@zufuliu zufuliu reopened this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants