Skip to content

workflow/autobump: stop relying on autobump.txt file #211313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

botantony
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@botantony botantony force-pushed the workflow_autobump branch 2 times, most recently from a51b6c2 to e3a17e4 Compare May 6, 2025 16:09
Signed-off-by: botantony <antonsm21@gmail.com>
@botantony botantony force-pushed the workflow_autobump branch from e3a17e4 to a59ba54 Compare May 6, 2025 16:13
HOMEBREW_GITHUB_API_TOKEN: ${{ secrets.HOMEBREW_CASK_REPO_WORKFLOW_TOKEN }}
HOMEBREW_GIT_COMMITTER_NAME: BrewTestBot
HOMEBREW_GIT_COMMITTER_EMAIL: 1589480+BrewTestBot@users.noreply.github.com
run: brew bump --no-fork --open-pr --cask --auto --tap=Homebrew/cask
Copy link
Member

@bevanjkay bevanjkay May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still skip running brew bump on Casks that use the :extract_plist for livecheck?
If it does, we should probably skip them by default here (without having to add no_autobump! to all of them).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of other cases when we do not need to use autobump and can detect it automatically?

Copy link
Member

@krehel krehel May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, files with version :latest should be ignored - which includes a majority of the fonts distributed.

:extract_plist should be ignored (as it is today) because of the negative impact on CI time, though we've done a lot of cleanup in this space within the last year and made efforts specifically to evaluate if :extract_plist was needed. We drove the count of those files down significantly.

That said, it could be worth exploring a one time per day job for just :extract_plist and see if it causes problems.

FWIW, just running some quick point in time stats in the Casks dir shows 7480 Casks, and we can ignore 3090 of them for matching deprecate! | disable! | :extract_plist | version :latest

We're autobumping close to 1800 Casks, or about ~41% of eligible apps. At this point there are very few PR's for version bumps that aren't already autobumped. It is likely if an application is bumped within every few months, it is already included in the list, though as always there's probably some we haven't included. Meaning, if it's not included already it probably gets an update at most once or twice a year, or hasn't been updated in an extended period of time.

@bevanjkay
Copy link
Member

@botantony Does anything further need to happen before we can try moving forward with this?
Any Cask that isn't in autobump.txt can't currently be bumped with brew bump or brew bump-cask-pr because after the related changes in Homebrew/brew they are being detected as "autobumped".

Example;

 ~  brew bump google-chrome
==> google-chrome
Cask is autobumped so will have bump PRs opened by BrewTestBot every ~3 hours.

The same applies for homebrew-core at the moment as well.

@botantony
Copy link
Contributor Author

It should be good to go once Homebrew/brew#19910 is merged and some casks are excluded from autobump manually (if needed)

@bevanjkay
Copy link
Member

@botantony There's also a CI failure in this PR that needs to be resolved before this can be merged.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label May 31, 2025
@github-actions github-actions bot closed this Jun 7, 2025
@botantony botantony deleted the workflow_autobump branch June 14, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip stale Issue which has not received any feedback for some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants