jetdrive-toolbox 4.5 (new cask)

[onnimonni]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

• Named the cask according to the token reference.
• Checked the cask was not already refused (add your cask's name to the end of the search field).
• brew audit --cask --new <cask> worked successfully.
• HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
• brew uninstall --cask <cask> worked successfully.

---

It's a quite cheap way to expand macbook storage with 1TB SD card from Transcend. Yes it's slow but it works.

The only problem is that MacOS automatically ejects the SD-card when power saving gets toggled and then contents can be corrupted and the SD-card doesn't get automatically mounted when the machine is used next time.

The included cask fixes these power saving issues.

[bevanjkay]

Thank you @onnimonni
I have left a couple of comments for review.

[onnimonni]

Thanks for the fixes to the PR.

It still seems to fail on intel machines and at least when I checked on my computer the installed app works only on ARM cpus:

$ file /Applications/JetDriveToolbox.app/Contents/MacOS/JetDriveToolbox
/Applications/JetDriveToolbox.app/Contents/MacOS/JetDriveToolbox: Mach-O 64-bit executable arm64

I will still alter the depends_on to skip this cask for Intel based macs.

[onnimonni]

I tried to look at other repos and I hope that by including only arm arch it's enough to skip intel based tests.

[khipp]

I tried to look at other repos and I hope that by including only arm arch it's enough to skip intel based tests.

We can specify the hardware requirement using depends_on arch: :arm64 (see documentation). Intel-based tests will then be skipped.

Never mind, you were faster! 😄

[onnimonni]

Never mind, you were faster! 😄

Well only by few seconds 😅. Thanks for the help anyway!

Homebrew is such a nice community and it's far easier to get stuff merged here than eg in nix packages.

I'm super happy that you improved the formula with the :header_match option and @bevanjkay gave meaningful review too.

If I can help in anyway let me know 🙇

[khipp]

Should be good to go now. Thanks, @onnimonni!