Skip to content

various: condense or remove unnecessary stanzas #212798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 21, 2025
Merged

Conversation

EricFromCanada
Copy link
Member

Almost entirely style fixes.

@EricFromCanada EricFromCanada added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label May 18, 2025
@khipp
Copy link
Member

khipp commented May 18, 2025

Dropping the requires_rosetta caveats seems to cause audit failures on affected macOS versions:

❯ brew audit --cask --online --strict birdfont --os mojave
==> Downloading and extracting artifacts
==> Downloading https://birdfont.org/download/birdfont-4.17.0-free.dmg
==> Verifying checksum for '079020bb8ae83904a66259a3e46b7686e583708eaac62bb7bdbffcb61f66563c--birdfont-4.17.0-free.dmg'
audit for birdfont: failed
 - Artifacts require Rosetta 2 but this is not indicated by the caveats!
birdfont
  * line 36, col 2: Artifacts require Rosetta 2 but this is not indicated by the caveats!
Error: 1 problem in 1 cask detected.
❯ brew audit --cask --online --strict reaper --os mojave
==> Downloading and extracting artifacts
==> Downloading https://dlcf.reaper.fm/7.x/reaper739_x86_64.dmg
==> Verifying checksum for 'a27d3fa1fa3b8ee1d1104ad626e7109c107ea406fe64a8f2a903469f2656e629--reaper739_x86_64.dmg'
audit for reaper: failed
 - Artifacts require Rosetta 2 but this is not indicated by the caveats!
reaper
  * line 7, col 4: Artifacts require Rosetta 2 but this is not indicated by the caveats!
Error: 1 problem in 1 cask detected.

@EricFromCanada
Copy link
Member Author

Seems like an audit bug, since Intel-only OS versions by definition don't need Rosetta 2. I'll look into it.

@EricFromCanada EricFromCanada added this pull request to the merge queue May 21, 2025
Merged via the queue into master with commit 4eb0b9d May 21, 2025
13 checks passed
@EricFromCanada EricFromCanada deleted the various-condense branch May 21, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants