-
Notifications
You must be signed in to change notification settings - Fork 1.7k
C++: Do not limit second level scopes to the top-level #19269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5efd5d4
to
4751b97
Compare
4751b97
to
3b5be53
Compare
3b5be53
to
9396f0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. I want to take a quick look at the DCA results then I expect to approve this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DCA results look like a similar-ish distribution to the QA run. New results look plausible to me. Your assessment seems to imply that the lost results all make sense in that there are flow complexities involving if
/ switch
that may have been affected by these changes. It looks like performance impact doesn't show up on DCA, which is also expected I think as the change affects a minority of projects strongly.
No description provided.