-
Notifications
You must be signed in to change notification settings - Fork 62.9k
Closed
Labels
contentThis issue or pull request belongs to the Docs Content teamThis issue or pull request belongs to the Docs Content teamfix-internallyTriggers a workflow to copy the issue internally and close the current issueTriggers a workflow to copy the issue internally and close the current issue
Description
This guard
docs/.github/workflows/moda-ci.yaml
Line 39 in 190a7a5
if: ${{ github.repository == 'github/docs-internal' }} |
did not prevent:
Invalid workflow file: .github/workflows/moda-ci.yaml#L86
error parsing called workflow
".github/workflows/moda-ci.yaml"
-> "github/internal-actions/.github/workflows/docker_security.yml@main"
: workflow was not found. See https://docs.github.com/actions/learn-github-actions/reusing-workflows#access-to-reusable-workflows for more information.
I think it might be possible to avoid this structure by using a combination of a workflow_call
with a jobs:
/ if:
condition that guards against the user from tripping on the problem e.g. ${{ github.repository == 'github/docs-internal' }}
and then have the on: workflow_call
on the internal side be responsible for using the reusable workflow.
Originally posted by @jsoref in #34562 (comment)
Metadata
Metadata
Assignees
Labels
contentThis issue or pull request belongs to the Docs Content teamThis issue or pull request belongs to the Docs Content teamfix-internallyTriggers a workflow to copy the issue internally and close the current issueTriggers a workflow to copy the issue internally and close the current issue