Skip to content

refactor(label-filters): improve the label filtering #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

nobe4
Copy link
Contributor

@nobe4 nobe4 commented Apr 10, 2025

This removes --label and --ignore-label in favor of only using --labels
and --ignore-labels. Having a singular and plural version caused
confusion and created additional code checks that weren't needed.

It also create some new tests to check for validity of the new logic.

Note that it changes the prLabels from undefined []struct{} to []string.
Eventually it might go back to []PR once it's properly defined. But
until then we can use strings only.

nobe4 added 2 commits April 10, 2025 11:13
This removes --label and --ignore-label in favor of only using --labels
and --ignore-labels. Having a singular and plural version caused
confusion and created additional code checks that weren't needed.

It also create some new tests to check for validity of the new logic.

Note that it changes the prLabels from undefined []struct{} to []string.
Eventually it might go back to []PR once it's properly defined. But
until then we can use strings only.
All those tests need to be rewritten eventually, so that's fine.
@nobe4 nobe4 requested a review from GrantBirki as a code owner April 10, 2025 09:16
@GrantBirki
Copy link
Member

@nobe4 this looks great! I'll merge this, update the examples in the main README, and then cut a new release.

@GrantBirki GrantBirki merged commit fcc1f1e into main Apr 10, 2025
6 checks passed
@GrantBirki GrantBirki deleted the filter-labels branch April 10, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants