Skip to content

feat(golangci): add linter and action to run golangci-lint #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 11, 2025

Conversation

nobe4
Copy link
Contributor

@nobe4 nobe4 commented Apr 11, 2025

Currently running with the default config.

@nobe4 nobe4 requested a review from GrantBirki as a code owner April 11, 2025 09:34
@GrantBirki
Copy link
Member

@nobe4 thank you for this! ❤️

I cleaned up the labelsMatch() function as I see you made a minor change to it, and added a whole bunch more tests to it covering edge cases.

@GrantBirki GrantBirki merged commit 1fa8554 into main Apr 11, 2025
7 checks passed
@GrantBirki GrantBirki deleted the golangci branch April 11, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants