-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
A clear and concise description of what the bug is.
Affected version
Please run docker run -i --rm ghcr.io/github/github-mcp-server ./github-mcp-server --version
and paste the output below
Steps to reproduce the behavior
- Run
golangci-lint run
with golangci version >= 2.
Expected vs actual behavior
Running golangci-lint run
returns an error.
Error: can't load config: can't unmarshal config by viper (flags, file): 1 error(s) decoding:
* 'output.formats' expected a map, got 'string'
Failed executing command with error: can't load config: can't unmarshal config by viper (flags, file): 1 error(s) decoding:
* 'output.formats' expected a map, got 'string'
Logs
I'm trying to setup the project in my local machine by going through the CONTRIBUTING guide. And running golangci-lint run
returns this error.
I noticed that the .golangci.yml
was migrated to the latest config. Is migrating the config is the right thing to do?
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
williammartin commentedon May 6, 2025
golangci-lint version 2 is only 6 weeks old or so (https://github.com/golangci/golangci-lint/releases/tag/v2.0.0) and we haven't updated our CI from version 1 (https://github.com/github/github-mcp-server/blob/e56c096e398faf9cf49f528816c208d931f9d834/.github/workflows/lint.yaml)
I would welcome a PR that fixes this, and updates our CI and documentation to require golangci-lint version 2.
radar07 commentedon May 6, 2025
I would love to raise a PR and am looking forward to some suggestions.