Skip to content

Check doesn't start for certain changes #763

@ldunkum

Description

@ldunkum

Problem Description

What is actually happening

The check for a PR is not starting, it's stuck at:

Starting NOP

initiating...

The PR only adds the following snippet for a repository:

security:
  enableVulnerabilityAlerts: false
  enableAutomatedSecurityFixes: false

I've checked the permissions of the GitHub app and can't find any missing permissions.

What is the expected behavior

That the check starts and shows changes from the PR.

Error output, if available

We can see this in the container logs and in the GitHub app event log, the event type is check_run.created.

  "stack": "TypeError: Cannot read properties of undefined (reading 'additions')\n    at /opt/safe-settings/lib/settings.js:245:29\n    at Array.reduce (<anonymous>)\n    at Settings.handleResults (/opt/safe-settings/lib/settings.js:237:16)\n    at async Settings.sync (/opt/safe-settings/lib/settings.js:52:7)\n    at async Promise.all (index 0)\n    at async Promise.all (index 0)\n    at async middleware (/opt/safe-settings/node_modules/probot/node_modules/@octokit/webhooks/dist-node/index.js:355:5)",
  "type": "Error",
  "msg": "Cannot read properties of undefined (reading 'additions')"

Context

Are you using the hosted instance of probot/settings or running your own?

Selfhosted

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

2.1.16

Version of GitHub Enterprise

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions