Skip to content

Excluding labels will still show as deletion #764

@stokkie90

Description

@stokkie90

Problem Description

When configuring labels.exclude to exclude some/all labels it will still show as a Deletion in PR context. After some looking into the code i think it shouldn't actually run the delete API call. (in NOP mode it also doesn't print the delete message) Link to exclude code block.

What is actually happening

  • Showing labels that should be exluded in the deletion column!

What is the expected behavior

  • Do not show any excluded labels in the PR Comment.

Context

Are you using the hosted instance of probot/settings or running your own?

self-hosted

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

2.1.16

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions