Skip to content

updated file input #6447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

lendrik-kumar
Copy link

@lendrik-kumar lendrik-kumar commented May 15, 2025

Description

This PR fixes #

Notes for Reviewers
the file input bar in new comer form, previously it required a text, now it can be uploaded from system

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sanket <sanketkamboj2006@gmail.com>
Copy link

github-actions bot commented May 15, 2025

@l5io
Copy link
Contributor

l5io commented May 15, 2025

🚀 Preview for commit 942b50b at: https://6825cbb3efaa66a37c5f89e2--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented May 16, 2025

🚀 Preview for commit 0c992b2 at: https://682731326229806690728a93--layer5.netlify.app

Copy link

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lendrik-kumar I don't get the purpose behind changing type to file for a url field.
I can't think of a scenario where someone would upload a file rom their system to update a LinkedIn url field. Am I missing something 🤔?

@lendrik-kumar
Copy link
Author

lendrik-kumar commented May 16, 2025

@vishalvivekm it asks for a file with extension jpeg, png like it asks for file from your system. I was just filling the form and came across this issue.

@vishalvivekm
Copy link

@lendrik-kumar I think you mean to mention picture field and not linkedin url one.
We don't support file upload for picuters: see #5477 (comment)

closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants