Skip to content

typekits is APIs should accept Entity or unknown #7185

@chrisradek

Description

@chrisradek

Currently - many of the typekit is APIs are too restrictive in what they accept. For example, $.value.is realistically only accepts a Value type:

is(type: { valueKind: string }): type is Value;

This makes it really hard to use these APIs with other methods that return Type | Value or Entity to narrow the types.

I think in general we should encourage that is* APIs support passing in either Entity or unknown.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions