Skip to content

Fix perf regression client e2e #7192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Apr 30, 2025

@joseharriaga found this and doesn't do anything. Because babel is not installed anymore with the alloy cli the npx command tries to install the package(I think) slowing down the e2e generation from ~35s to ~150s

Copy link
Contributor

github-actions bot commented Apr 30, 2025

All changed packages have been documented.

  • @typespec/http-client-js
Show changes

@typespec/http-client-js - internal ✏️

Fix perf regression client e2e and extra perf gain with compiler api

@timotheeguerin timotheeguerin changed the title Fix perf regression client e2e Fix perf regression client e2e and extra perf gain with compiler api Apr 30, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 30, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin timotheeguerin force-pushed the fix/perf-regression-client-js-e2e branch 2 times, most recently from 201a58d to 7adbe36 Compare April 30, 2025 20:31
@timotheeguerin timotheeguerin changed the title Fix perf regression client e2e and extra perf gain with compiler api Fix perf regression client e2e May 5, 2025
@timotheeguerin timotheeguerin enabled auto-merge May 5, 2025 16:13
@timotheeguerin timotheeguerin added this pull request to the merge queue May 5, 2025
Merged via the queue into microsoft:main with commit 684ba2a May 5, 2025
22 checks passed
@timotheeguerin timotheeguerin deleted the fix/perf-regression-client-js-e2e branch May 5, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:js Issue for the JS client emitter: @typespec/http-client-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants