You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds some features and fixes a couple of bugs in the visibility transforms.
@withVisibilityFilter now accepts a nameTemplate optional argument that is used to rename named types as they are transformed.
@withVisibilityFilter now correctly completely ignores any type that is not subject to visibility transforms. Previously, it was still mutating/cloning types that were not subject to the transform, like Scalar types, even if it didn't transform them.
@withVisibilityFilter now caches transforms so that applications of the same visibility filter with the same name template now return identical result objects, reducing the number of structurally equivalent models/unions that are created.
@withVisibilityFilter now correctly considers the indexer of Model types, allowing it to work correctly on Array and Record types.
@withLifecycleUpdate also receives the above modifications.
Confirmed that this addresses the following issues in a local playground instance.
Added an optional nameTemplate argument to @withVisibilityFilter, allowing the visibility filters to rename models as they are transformed. This template is applied by default in the Create, Read, Update, Delete, and Query visibility transform templates. This allows for more flexible renaming than simply using the @friendlyName decorator, as it will change the primary name of the transformed type, reducing the incidence of naming conflicts.,> ,> Cached the result of applying visibility filters to types. If the same visibility filter is applied to the same type with the same configuration, the model instance produced by the visibility filter will be object-identical. This should reduce the incidence of multiple models that are structurally equivalent in visibility filters and conflicts over the name of models.
Fixed an error in Model visibility filtering where the indexer of a model was ignored. This prevented the value of Array/Record instances from being transformed correctly, as they now should be.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
witemple-msft
requested review from
bterlson,
markcowl,
allenjzhang,
timotheeguerin,
chrisradek and
AlitzelMendez
as code owners
This PR adds some features and fixes a couple of bugs in the visibility transforms.
@withVisibilityFilternow accepts anameTemplateoptional argument that is used to rename named types as they are transformed.@withVisibilityFilternow correctly completely ignores any type that is not subject to visibility transforms. Previously, it was still mutating/cloning types that were not subject to the transform, like Scalar types, even if it didn't transform them.@withVisibilityFilternow caches transforms so that applications of the same visibility filter with the same name template now return identical result objects, reducing the number of structurally equivalent models/unions that are created.@withVisibilityFilternow correctly considers the indexer of Model types, allowing it to work correctly on Array and Record types.@withLifecycleUpdatealso receives the above modifications.Confirmed that this addresses the following issues in a local playground instance.
Closes #7016
Closes #7072
TODO before merging: