Skip to content

[typekits] update is* typekits to accept Entity instead of Type or Value #7204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 2, 2025

Conversation

chrisradek
Copy link
Member

Fixes #7185

Updates is* methods to accept Entity now.

Also did some extra cleanup:

  • Removed @experimental jsdoc tags that were missed before
  • Moved $.resolve to $.entity.resolve since we now have $.type.resolve and $.value.resolve which are preferable to use.

Copy link
Contributor

github-actions bot commented May 1, 2025

All changed packages have been documented.

  • @typespec/compiler
Show changes

@typespec/compiler - feature ✏️

Update typekits is* methods to accept Entity instead of just Type or Value

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 1, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@chrisradek chrisradek enabled auto-merge May 2, 2025 18:47
@chrisradek chrisradek added this pull request to the merge queue May 2, 2025
Merged via the queue into microsoft:main with commit 1c6fda8 May 2, 2025
22 checks passed
@chrisradek chrisradek deleted the tk-better-is branch May 2, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typekits is APIs should accept Entity or unknown
3 participants