Fix building capybarakv on Linux without PMDK #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building on Linux without PMDK requires disabling the "pmem" feature in deps_hack, which requires using "default-features = false" for that dependency. The capybarakv "pmem" feature (enabled by default) does explicitly enable the deps_hack "pmem" feature, so everything still works the same by default (requiring PMDK), but now "cargo build --no-default-features" and "cargo test --no-default-features" in capybarakv work even if PMDK is not installed.
|
Thanks, Nickolai! I'll try to test this soon so we can merge it. |
hayley-leblanc
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on Linux without PMDK requires disabling the "pmem" feature in deps_hack, which requires using "default-features = false" for that dependency. The capybarakv "pmem" feature (enabled by default) does explicitly enable the deps_hack "pmem" feature, so everything still works the same by default (requiring PMDK), but now "cargo build --no-default-features" and "cargo test --no-default-features" in capybarakv work even if PMDK is not installed.