Add chat participant request handler to support GH chat #19283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial chat handler implementation
kburtram
requested review from
aasimkhan30,
cssuh,
caohai,
laurenastrid1,
lewis-sanchez and
Benjin
as code owners
kburtram
commented
Apr 28, 2025
PR Changes
|
* Capture telemetry around actions * Add telemetry around helpful/unhelpful responses * Minor clean up * Register disposable * ToolCall and error telemetry * Add telemetry for chat with database action * Telemetry for conversation start and end. * Add original error message * Minor clean up * Rename telemetry view to MssqlCopilot * Call start activity at top of handler * Use a correlation ID + tie it in with other handler telemetry
…nto dev/chathandler
Benjin
reviewed
May 6, 2025
lewis-sanchez
approved these changes
May 6, 2025
caohai
approved these changes
May 6, 2025
lewis-sanchez
approved these changes
May 6, 2025
12 tasks
|
Follow-up issue with telemetry suggestions #19361 |
12 tasks
|
Error message localization follow-up issue #19362 |
|
I also created a follow-up issue for the OE entry point integration here #19360 |
12 tasks
|
Follow-up issue to consider logging channel #19363. |
Benjin
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of GH Chat Participant API. The majority of the chat and tool call handling is here microsoft/sqltoolsservice#2474.