Skip to content

Flattening tests in test_cli.py #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Flattening tests in test_cli.py #21

wants to merge 2 commits into from

Conversation

pydanny
Copy link
Contributor

@pydanny pydanny commented May 5, 2025

While this looks like a HUGE change, in reality it is minimal. What it does:

  1. Replaces use of the tempfile.TemporaryDirectory() context processor with the tmp_path pytest fixture, which provides a Path object instead of a string
  2. Using this fixture flattens the code, making it easier to read and maintain

Note

This will be pulled out of draft once the other tests are converted to use tmp_path

@pydanny pydanny self-assigned this May 5, 2025
@pydanny pydanny added the enhancement New feature or request label May 5, 2025
@jph00
Copy link
Contributor

jph00 commented Jun 7, 2025

@algal looks like there's some minor changes still needed based on the description before this can be merged.

@algal
Copy link
Contributor

algal commented Jun 9, 2025

@jph00 Yeah. I think this is still marked draft becaase it's not complete. It's not ready for review or merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants