Refactor integrations to format with ruff after dropping black #20452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datadog-agent-integrations-bot
bot
added
integration/btrfs
integration/couchbase
integration/marathon
dev/tooling
integration/http_check
integration/apache
integration/aspdotnet
integration/cacti
integration/cassandra_nodetool
integration/ceph
integration/consul
integration/directory
integration/disk
integration/dns_check
integration/dotnetclr
integration/ecs_fargate
integration/elastic
integration/envoy
integration/etcd
integration/gearmand
integration/gunicorn
integration/haproxy
integration/iis
integration/istio
integration/kafka_consumer
integration/kong
integration/kube_dns
integration/kube_proxy
integration/kubelet
integration/kubernetes_state
labels
AAraKKe
force-pushed
the
aarake/format-all-integrations-with-ruff
branch
from
3d4eb3f to
73e4745
Compare
AAraKKe
force-pushed
the
aarake/small-tweaks-for-devx
branch
from
4c70675 to
a6f9a43
Compare
AAraKKe
force-pushed
the
aarake/format-all-integrations-with-ruff
branch
2 times, most recently
from
808ceaf to
edca816
Compare
AAraKKe
force-pushed
the
aarake/small-tweaks-for-devx
branch
from
a6f9a43 to
598d124
Compare
AAraKKe
force-pushed
the
aarake/format-all-integrations-with-ruff
branch
from
edca816 to
9b24a6b
Compare
AAraKKe
force-pushed
the
aarake/small-tweaks-for-devx
branch
from
598d124 to
0cf2163
Compare
AAraKKe
force-pushed
the
aarake/format-all-integrations-with-ruff
branch
from
9b24a6b to
cb4ee8b
Compare
AAraKKe
force-pushed
the
aarake/small-tweaks-for-devx
branch
from
0cf2163 to
909e654
Compare
AAraKKe
force-pushed
the
aarake/format-all-integrations-with-ruff
branch
from
cb4ee8b to
2c3c935
Compare
AAraKKe
force-pushed
the
aarake/small-tweaks-for-devx
branch
from
909e654 to
c6fb13a
Compare
AAraKKe
force-pushed
the
aarake/format-all-integrations-with-ruff
branch
2 times, most recently
from
e3f39c1 to
7bdac01
Compare
AAraKKe
force-pushed
the
aarake/small-tweaks-for-devx
branch
from
c6fb13a to
8f65df9
Compare
AAraKKe
force-pushed
the
aarake/format-all-integrations-with-ruff
branch
from
7bdac01 to
3f42dd2
Compare
|
/mergegate trigger |
|
View all feedbacks in Devflow UI.
Merge gate not updated, no change detected in status or details on integrations-core #20452 synced on DB: failure |
AAraKKe
force-pushed
the
aarake/format-all-integrations-with-ruff
branch
6 times, most recently
from
3f42dd2 to
ef074e9
Compare
AAraKKe
force-pushed
the
aarake/format-all-integrations-with-ruff
branch
from
c932e7b to
c988282
Compare
|
Alright, the check pr fails because the diff is too big and we cannot get the entire body to validate changelogs. I am bypassing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR runs ruff formatter in all integrations following the previous PR #20451.
Motivation
While Ruff is mostly a drop in replacement of Black there are some rules for which ruff can decide to format things different. See their differences with black page here.
Ruff brings faster formatting than Black and more reasonable defaults in many cases but this means that due to the differences in some situations, formatting would be a bit different.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged