Skip to content

Add segment editing mode to the Path tool #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 30, 2025
Merged

Add segment editing mode to the Path tool #2712

merged 20 commits into from
Jun 30, 2025

Conversation

4adex
Copy link
Collaborator

@4adex 4adex commented Jun 13, 2025

Closes #696. Resolves part 1 of #2716.

@otdavies
Copy link
Member

chrome_dCHxDTROZq_compressed.mp4

This should only allow selecting both an edge and a point when I am holding shift. I wasn't holding shift here. (no modifier keys at all)

Awesome feature btw, good progress!

@4adex
Copy link
Collaborator Author

4adex commented Jun 14, 2025

@otdavies Yes I am working upon it, will push the latest code with some other additions.

@Keavon Keavon force-pushed the master branch 2 times, most recently from 34dced3 to 5cacab2 Compare June 20, 2025 06:47
@Keavon Keavon force-pushed the segment_editing_mode branch from 0761cc4 to f8bf199 Compare June 20, 2025 06:57
@Keavon Keavon changed the title Segment Editing Mode similar to blender's point/ segment/ region selection modes Add segment editing mode to the Path tool Jun 23, 2025
@Keavon Keavon marked this pull request as draft June 24, 2025 00:24
@4adex 4adex marked this pull request as ready for review June 24, 2025 13:18
@Keavon Keavon force-pushed the master branch 2 times, most recently from 316a737 to 532e913 Compare June 28, 2025 13:25
@Keavon
Copy link
Member

Keavon commented Jun 30, 2025

Awesome start, this is great to have!

QA improvements for a follow-up PR:

  • Disabling all modes shouldn't be possible.
  • We want it to act more like radio buttons but where Shift can multi-select, like in Blender (but I may need to figure out a more refined design for radios vs. checkboxes when the lines between the two are blurred as they are in this case).
  • Switching from segment mode to point mode should make the points connected to each segment become selected, like in Blender, and vice versa where two neighboring points cause their shared segment to become selected. And in segment only mode, selecting two adjacent segments should automatically select their shared point (but not in segment + point mode).
  • Didn't we discuss a hotkey (maybe Ctrl or Alt?) to let you insert a point on a segment even if you're in segment selection mode? That should also be the same hotkey for molding when you drag instead of click, instead of currently using A which isn't a standard modifier key.
  • Now that we have the hover highlight over segments before clicking to select them, we should have the same for anchors— that can take the form of a 1px (in all directions) rectangle with the same semitransparent blue used for the pre-selection segment hover.
  • I love the dynamic contextual input hints, and it would be good to have that also happen when hovering over an anchor, not just a segment.

@Keavon Keavon merged commit 391ed34 into master Jun 30, 2025
4 checks passed
@Keavon Keavon deleted the segment_editing_mode branch June 30, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Points/segments/shapes vector selection mode
3 participants