Skip to content

Improve node creation menu and categorization #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

Ezbaze
Copy link
Contributor

@Ezbaze Ezbaze commented Jun 15, 2025

  • Fix the clickability area of categories in the node editor context menu to close Category text label isn't clickable in the Node Graph editor context menu #2718
  • Node editor context menu nodes category swaps:
    1. Circular Repeat: Vector → Instancing
    2. Copy to Points: Vector → Instancing
    3. Repeat: Vector → Instancing
    4. Switch: Text → Math: Logic
  • Organize code for certain nodes across files to reflect their new categories

Also resolves https://discordapp.com/channels/731730685944922173/881073965047636018/1383884104566706217 and https://discordapp.com/channels/731730685944922173/881073965047636018/1384323535316713542

@Ezbaze Ezbaze changed the title Fix clickability area of categories in the node editor context menu Node editor context menu & Node categories Jun 16, 2025
@Keavon Keavon force-pushed the master branch 2 times, most recently from 34dced3 to 5cacab2 Compare June 20, 2025 06:47
@Keavon Keavon force-pushed the node-editor-context-menu branch from 57dc1b7 to f9470bc Compare June 20, 2025 07:35
@Keavon
Copy link
Member

Keavon commented Jun 20, 2025

I have force pushed this branch to move it to a new base. Ensure you have the branch checked out. Then run git stash on any local changes (and ask me before following these steps if you have any un-pushed commits on your local machine). Then fetch this branch and git reset --hard origin/node-editor-context-menu. And finally git stash pop your stashed local changes, if you stashed them.

@Keavon Keavon changed the title Node editor context menu & Node categories Improve node creation menu and categorization Jun 23, 2025
@Firestar99
Copy link
Collaborator

I'd love to get this merged before I'm rearranging all the vector code and nodes into separate crates :D

@Keavon
Copy link
Member

Keavon commented Jun 23, 2025

@Firestar99 these are easy to replay on the latest master branch in the future, so no need to let this block you. When you're moving the node implementations around, feel free to reference this issue for how some of them got recategorized.

@Ezbaze Ezbaze closed this Jun 23, 2025
@Ezbaze Ezbaze force-pushed the node-editor-context-menu branch from f9470bc to 59bb319 Compare June 23, 2025 18:59
Signed-off-by: ezbaze <rybitwamateusz3@gmail.com>
@Ezbaze Ezbaze reopened this Jun 23, 2025
@Keavon Keavon force-pushed the node-editor-context-menu branch from 89d0585 to cbeecda Compare June 24, 2025 01:36
@Keavon Keavon merged commit 2ec0ff3 into GraphiteEditor:master Jun 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Category text label isn't clickable in the Node Graph editor context menu
3 participants