Skip to content

Running Istanbul changes number of tests that are executed #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itsjamie opened this issue Feb 15, 2019 · 3 comments
Closed

Running Istanbul changes number of tests that are executed #1

itsjamie opened this issue Feb 15, 2019 · 3 comments
Labels
needs more info More information or actions are needed before the issue can be addressed

Comments

@itsjamie
Copy link

Hello!

We're running tests in Karma, and while on master we're using istanbul-instrumenter-loader normally, I tested your package to see if it fixed our issue since you've upgraded to the newer APIs, but it was still demonstrating the issue.

We noticed that while running tests through karma-webpack, and using this package to get coverage numbers, the number of tests that are run changes between runs.

I tested removing this package and all unit tests are run every time, and I cannot reproduce the issue, so it seems that running this module is causing our setup to act oddly.

Any ideas as to what might be happening?

Our issue tracking this: video-dev/hls.js#2125

@JamesMessinger
Copy link
Member

Very odd. I've never seen that behavior before. I think the best thing to do is create a minimal reproduction of the issue, so we can more easily hone in on the root cause.

I'd suggest that you create a new GitHub repo from scratch and slowly start adding as little code as possible and as few libraries as possible until you're able to reproduce the bug. Then start removing things one at a time to see which thing changes the behavior. Once you've nailed it down, you can link me to the repo and I'll take a look.

@JamesMessinger JamesMessinger added the needs more info More information or actions are needed before the issue can be addressed label Feb 16, 2019
@itsjamie
Copy link
Author

Hey James, upgrading to Karma 3.1.4 and switching seems to have resolved our issue.

Thank you.

@JamesMessinger
Copy link
Member

Awesome! Great to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info More information or actions are needed before the issue can be addressed
Projects
None yet
Development

No branches or pull requests

2 participants