Fix deprecation warnings and enable warningsAsErrors for buildSrc #4464
Conversation
ALikhachev
force-pushed
the
ALikhachev/buildSrc-deprecation-warnings
branch
from
67f3371 to
8c3070a
Compare
K/JS related deprecation warnings are to be promoted to error within KT-68597 in Kotlin 2.2
ALikhachev
force-pushed
the
ALikhachev/buildSrc-deprecation-warnings
branch
from
8c3070a to
dc6d37b
Compare
| val currentValue = downloadBaseUrl.orNull | ||
| if (currentValue != null) { | ||
| downloadBaseUrl = CacheRedirector.maybeRedirect(currentValue) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can this not be written like it was before? That is,
| val currentValue = downloadBaseUrl.orNull | |
| if (currentValue != null) { | |
| downloadBaseUrl = CacheRedirector.maybeRedirect(currentValue) | |
| } | |
| } | |
| downloadBaseUrl.orNull?.let { | |
| downloadBaseUrl = CacheRedirector.maybeRedirect(it) | |
| } | |
| } |
I'd expect this to be a pure Kotlin construction, without any relation to what Gradle supports or doesn't support.
There was a problem hiding this comment.
Sure, it can be. If you prefer this style – I can update it. The comment above relates to the fact that orNull resolves the value of the property eagerly instead of applying a dynamic transformator on it
There was a problem hiding this comment.
I somewhat prefer the current style, but it's not important. I just got confused about what part of the change was important and which accidental.
| val currentValue = downloadBaseUrl.orNull | ||
| if (currentValue != null) { | ||
| downloadBaseUrl = CacheRedirector.maybeRedirect(currentValue) | ||
| } | ||
| } |
There was a problem hiding this comment.
I somewhat prefer the current style, but it's not important. I just got confused about what part of the change was important and which accidental.
K/JS related deprecation warnings are to be promoted to error within KT-68597 in Kotlin 2.2